Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-4762: clarify change in behaviour for CALLCODE cost if value transfer #9124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lu-pinto
Copy link

@lu-pinto lu-pinto commented Dec 10, 2024

I think the removal of CALLCODE cost for value transfer needs to be clarified and I didn't find any reference to it in the EIP. I remember that Besu bumped into this change and we actually applied the change to previous forks as well causing the CI pipeline to fail later on.

Even though it makes sense to not charge anything since CALLCODE transfers to itself, that's not the case with previous forks so this is a change in behaviour which IMO is worth documenting.

cc @gballet @jsign

@lu-pinto lu-pinto requested a review from eth-bot as a code owner December 10, 2024 16:40
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 10, 2024

File EIPS/eip-4762.md

Requires 1 more reviewers from @dankrad, @g11tech, @gballet, @jsign, @tanishqjasoria, @vbuterin

@eth-bot eth-bot added the a-review Waiting on author to review label Dec 10, 2024
@eth-bot eth-bot changed the title EIP-4762: clarify change in behaviour for CALLCODE cost if value transfer Update EIP-4762: clarify change in behaviour for CALLCODE cost if value transfer Dec 10, 2024
@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-core labels Dec 10, 2024
Copy link
Member

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few issues with this PR:

  • Why is CALLCODE special, all other static costs are also removed ( and have been since 2929/2930, this is not a 4762-specific change)
  • What other forks are you referring to ? Do you mean that value costs for value transfers no longer apply? We could clarify this if it makes sense, but what is the connection with the static costs?

@lu-pinto
Copy link
Author

lu-pinto commented Dec 11, 2024

I have a few issues with this PR:

* Why is `CALLCODE` special, all other static costs are also removed ( and have been since 2929/2930, this is not a 4762-specific change)

* What other forks are you referring to ? Do you mean that value costs for value transfers no longer apply? We could clarify this if it makes sense, but what is the connection with the static costs?

OK maybe static is not the right word, we can remove that. But current mainnet charges 9000 gas in CALLCODE, if there is value to be transferred, and in EIP4762 these charges have been removed, that's what I meant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants