Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to BLS precompiles (EIP-2537) #1089

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Updates to BLS precompiles (EIP-2537) #1089

wants to merge 3 commits into from
+62 −75

Conversation

chfast
Copy link
Member

@chfast chfast commented Dec 20, 2024

@chfast chfast added precompiles Related to EVM precompiles Prague Changes for Prague upgrade labels Dec 20, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.58%. Comparing base (50b095c) to head (64d0901).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
test/state/precompiles.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1089      +/-   ##
==========================================
- Coverage   94.31%   93.58%   -0.73%     
==========================================
  Files         159      159              
  Lines       17221    17207      -14     
==========================================
- Hits        16242    16104     -138     
- Misses        979     1103     +124
Flag Coverage Δ
eof_execution_spec_tests 23.64% <0.00%> (+0.01%) ⬆️
ethereum_tests 26.65% <0.00%> (+0.02%) ⬆️
ethereum_tests_silkpre 18.96% <0.00%> (+0.01%) ⬆️
execution_spec_tests ?
unittests 89.14% <25.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/unittests/state_precompiles_test.cpp 100.00% <100.00%> (ø)
test/state/precompiles.cpp 69.92% <0.00%> (-29.01%) ⬇️

... and 4 files with indirect coverage changes

@chfast chfast requested a review from rodiazet December 20, 2024 09:24
@chfast
precompiles: Update gas costs for BLS precompiles
4c6470b 
This updates the gas costs of BLS precompiles.
Discounts tables for MSMs are not split between G1 and G2 variants.
We additionally pre-process the tables to more directly consumable form.
@chfast
precompiles: Remove redundant BLS MUL precompiles
6e214c6 
Remove redundant G1/G2 MUL precompiles easily replaceable with MSMs.
Spec update: ethereum/EIPs#8945.
@chfast chfast force-pushed the precompiles/bls_updates branch from 9971bd0 to 6e214c6 Compare December 20, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodiazet rodiazet Awaiting requested review from rodiazet

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Prague Changes for Prague upgrade precompiles Related to EVM precompiles
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chfast