- don't unpin if selected provider

- focus on gridprovider - show no provider pinned
ethereum · May 13, 2024 · c63731e · c63731e
1 parent 2b98039
commit c63731e
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 15 deletions.
diff --git a/apps/remix-ide/src/app/providers/grid-providers.tsx b/apps/remix-ide/src/app/providers/grid-providers.tsx
@@ -107,9 +107,16 @@ export class GridProviders extends ViewPlugin {
               plugin={this}
               title={provider.name}
               pinned={this.pinnedProviders.includes(provider.name)}
-              pinStateCallback={(pinned: boolean) => {
-                this.emit(pinned ? 'providerPinned' : 'providerUnpinned', provider.name, provider)}
-              }
+              pinStateCallback={async (pinned: boolean) => {
+                const providerName = await this.call('blockchain', 'getProvider')
+                if (providerName !== provider.name) {
+                  this.emit(pinned ? 'providerPinned' : 'providerUnpinned', provider.name, provider)
+                  return true
+                } else {
+                  this.call('notification', 'toast', 'Cannot unpin the current selected provider')
+                  return false
+                }
+              }}
             >
               <div>{provider.name}</div>
             </RemixUIGridCell>
@@ -122,11 +129,18 @@ export class GridProviders extends ViewPlugin {
         >{this.providers['Remix VMs'].map(provider => {
             return <RemixUIGridCell
               plugin={this}
-              pinned={this.pinnedProviders.includes(provider.name)}
-              pinStateCallback={(pinned: boolean) => {
-                this.emit(pinned ? 'providerPinned' : 'providerUnpinned', provider.name, provider)}
-              }
               title={provider.name}
+              pinned={this.pinnedProviders.includes(provider.name)}
+              pinStateCallback={async (pinned: boolean) => {
+                const providerName = await this.call('blockchain', 'getProvider')
+                if (providerName !== provider.name) {
+                  this.emit(pinned ? 'providerPinned' : 'providerUnpinned', provider.name, provider)
+                  return true
+                } else {
+                  this.call('notification', 'toast', 'Cannot unpin the current selected provider')
+                  return false
+                }
+              }}
             >
               <div>{provider.name}</div>
             </RemixUIGridCell>
@@ -138,11 +152,18 @@ export class GridProviders extends ViewPlugin {
         >{this.providers['Externals'].map(provider => {
             return <RemixUIGridCell
               plugin={this}
-              pinned={this.pinnedProviders.includes(provider.name)}
-              pinStateCallback={(pinned: boolean) => {
-                this.emit(pinned ? 'providerPinned' : 'providerUnpinned', provider.name, provider)}
-              }
               title={provider.name}
+              pinned={this.pinnedProviders.includes(provider.name)}
+              pinStateCallback={async (pinned: boolean) => {
+                const providerName = await this.call('blockchain', 'getProvider')
+                if (providerName !== provider.name) {
+                  this.emit(pinned ? 'providerPinned' : 'providerUnpinned', provider.name, provider)
+                  return true
+                } else {
+                  this.call('notification', 'toast', 'Cannot unpin the current selected provider')
+                  return false
+                }
+              }}
             >
               <div>{provider.name}</div>
             </RemixUIGridCell>

diff --git a/apps/remix-ide/src/blockchain/blockchain.tsx b/apps/remix-ide/src/blockchain/blockchain.tsx
@@ -531,7 +531,7 @@ export class Blockchain extends Plugin {
 
   changeExecutionContext(context, confirmCb, infoCb, cb) {
     if (context.context === 'item-another-chain') {
-      this.call('manager', 'activatePlugin', 'gridProviders')
+      this.call('manager', 'activatePlugin', 'gridProviders').then(() => this.call('tabs', 'focus', 'gridProviders'))
     } else {
       return this.executionContext.executionContextChange(context, null, confirmCb, infoCb, cb)
     }

diff --git a/libs/remix-ui/grid-view/src/lib/remix-ui-grid-cell.tsx b/libs/remix-ui/grid-view/src/lib/remix-ui-grid-cell.tsx
@@ -52,9 +52,8 @@ export const RemixUIGridCell = (props: RemixUIGridCellProps) => {
         </div>
         { filterCon.showPin && <button
           className={`${pinned ? 'fa-duotone' : 'fa-light'}` + ` fa-map-pin text-info border-0 mb-0 remixui_grid_cell_pin`}
-          onClick={() => {
-            setPinned(!pinned)
-            props.pinStateCallback(!pinned)
+          onClick={async () => {
+            if (await props.pinStateCallback(!pinned)) setPinned(!pinned)
           }}
         ></button>}
         { props.tagList && <div className='d-flex flex-column align-items-begin remixui_grid_cell_tags'>

diff --git a/libs/remix-ui/run-tab/src/lib/components/environment.tsx b/libs/remix-ui/run-tab/src/lib/components/environment.tsx
@@ -49,6 +49,11 @@ export function EnvironmentUI(props: EnvironmentProps) {
             )}
           </Dropdown.Toggle>
           <Dropdown.Menu as={CustomMenu} className="w-100 custom-dropdown-items" data-id="custom-dropdown-items">
+           {props.providers.providerList.length === 0 ? <Dropdown.Item>
+              <span className="">
+                No provider pinned
+              </span>
+            </Dropdown.Item> : ''}
             {props.providers.providerList.map(({ displayName, name }, index) => (
               <Dropdown.Item
                 key={index}