Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show erc list in editor #4107

Merged
merged 9 commits into from
Oct 4, 2023
Merged

show erc list in editor #4107

merged 9 commits into from
Oct 4, 2023

Conversation

Aniket-Engg
Copy link
Collaborator

@Aniket-Engg Aniket-Engg commented Oct 2, 2023

Show a list of listed erc interfaces and standards when user types erc in the editor.

On clicking enter, relevant code should be pasted in the code according to selection.

Inspired from: https://github.com/juanfranblanco/vscode-solidity/tree/master#erc-erc-drafts-and-smart-contracts-snippets--reference

erc details are fetched from: https://github.com/juanfranblanco/vscode-solidity/blob/master/snippets/solidity.json

@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 9a86638
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/651c2842cde15f00083b4068
😎 Deploy Preview https://deploy-preview-4107--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Aniket-Engg Aniket-Engg added editor Related to code editor WIP labels Oct 2, 2023
@Aniket-Engg Aniket-Engg added ready-to-review PR ready to review and removed WIP labels Oct 3, 2023
/* eslint-disable */
// Related to https://github.com/juanfranblanco/vscode-solidity/blob/master/snippets/solidity.json
{
label: 'erc20i',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably the labels should be more explicit, like generate erc20i for instance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw just wondering, do we already have snippet for generating loops?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably the labels should be more explicit, like generate erc20i for instance.

that is a keyword to show the list

Copy link
Collaborator Author

@Aniket-Engg Aniket-Engg Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably the labels should be more explicit, like generate erc20i for instance.

that is a keyword to show the list. We can update the detail field

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw just wondering, do we already have snippet for generating loops?

yes, we have

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is a keyword to show the list. We can update the detail field

yes, in https://github.com/juanfranblanco/vscode-solidity/raw/master/screenshots/ercautocomplete1.png
there's a quick and a full description associated with the keyword.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably the labels should be more explicit, like generate erc20i for instance.

that is a keyword to show the list. We can update the detail field

updated @yann300

@Aniket-Engg Aniket-Engg requested a review from yann300 October 3, 2023 14:42
@yann300
Copy link
Contributor

yann300 commented Oct 3, 2023

ok I see thanks for the update, is this also possible to add the full description, as in the screenshot above?

@Aniket-Engg
Copy link
Collaborator Author

ok I see thanks for the update, is this also possible to add the full description, as in the screenshot above?

it is there, when you click on > of particular option

@Aniket-Engg Aniket-Engg merged commit 6f7f567 into master Oct 4, 2023
5 checks passed
@Aniket-Engg Aniket-Engg deleted the ercList branch October 4, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Related to code editor ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants