Add Language Options to Settings #4112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joeizang
force-pushed
the
add-lang-options
branch
2 times, most recently
from
80fdd8f to
6632a25
Compare
joeizang
force-pushed
the
add-lang-options
branch
from
23ac4a3 to
2174fa2
Compare
ryestew
requested changes
Oct 25, 2023
| const _paq = window._paq = window._paq || [] | ||
|
|
||
| const locales = [ | ||
| { code: 'en', name: 'English', localeName: 'English', messages: enJson }, | ||
| { code: 'zh', name: 'Chinese Simplified', localeName: '简体中文', messages: zhJson }, | ||
| { code: 'es', name: 'Spanish', localeName: 'Español', messages: esJson }, |
There was a problem hiding this comment.
These should be alphabetized - well at least alphabetized in English - so the first entry of this list would be chinese.
joeizang
force-pushed
the
add-lang-options
branch
from
2174fa2 to
d3031f4
Compare
joeizang
force-pushed
the
add-lang-options
branch
2 times, most recently
from
bf852fc to
b67341e
Compare
ryestew
approved these changes
Oct 27, 2023
joeizang
force-pushed
the
add-lang-options
branch
from
b67341e to
33c1d68
Compare
|
we can add Italian to this list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4068