Dapp draft patch1 #4756
Merged
Dapp draft patch1 #4756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for remixproject pending review.Visit the deploys page to approve it
|
yann300
reviewed
Apr 24, 2024
| @@ -297,7 +297,7 @@ export function UniversalDappUI(props: UdappProps) { | |||
| <label> | |||
| <b><FormattedMessage id="udapp.balance" />:</b> {instanceBalance} ETH | |||
| </label> | |||
| {props.exEnvironment === 'injected' && <i className="fas fa-edit btn btn-sm p-0" onClick={() => {props.editInstance(props.instance)}}></i>} | |||
| {props.exEnvironment.indexOf('MetaMask') > -1 && <i className="fas fa-edit btn btn-sm p-0" onClick={() => {props.editInstance(props.instance)}}></i>} | |||
There was a problem hiding this comment.
why do you restrict it to metamask?
There was a problem hiding this comment.
oh ok i see... but we have to find another solution...
There was a problem hiding this comment.
can you rebase and remove that changes from this PR?
drafish
force-pushed
the
dapp-draft-patch1
branch
from
94813a6 to
a928e4d
Compare
yann300
approved these changes
Apr 30, 2024
auto-merge was automatically disabled
April 30, 2024 13:51
Head branch was pushed to by a user without write access
drafish
force-pushed
the
dapp-draft-patch1
branch
from
a928e4d to
57001ac
Compare
|
merging as the metamask test always fails for external PR, and this isn't linked to that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two more parameters to edit method, so that dapp-draft could auto input the instructions from devdoc.
@ryestew @yann300