-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add quick-dapp plugin #4844
add quick-dapp plugin #4844
Conversation
👷 Deploy request for remixproject pending review.Visit the deploys page to approve it
|
97f36df
to
b77bdb9
Compare
@drafish how would you recommend to add e2e test for the plugin and the site template? |
apps/quick-dapp/src/components/MultipleContainers/components/Item/Item.tsx
Outdated
Show resolved
Hide resolved
apps/quick-dapp/src/components/MultipleContainers/components/Item/components/Handle/Handle.tsx
Outdated
Show resolved
Hide resolved
apps/quick-dapp/src/components/MultipleContainers/components/Item/components/Remove/Remove.tsx
Outdated
Show resolved
Hide resolved
For the plugin
For the deployed dapp
By the end of the e2e test, we should delete the subdomain which has be deployed in the e2e test. For the dapp template, same as the e2e test for the deployed dapp.
|
@LianaHus could you review the UI once more? |
I think there is a better way to do e2e test for the dapp-template. For now, the dapp-template is in an individual repository. I have to do the e2e test in that repository. But what if I put it into to remix codebase, just like any other iframe plugins under folder And there is another advantage in this way. It will be easy to keep versions in sync between quick-dapp and dapp-template, because they are in the same repository. The only question is, can I put dapp-template into remix codebase, even it's not a remix plugin? @yann300 @ryestew |
yes I think we could do that, but first let's merge this PR, sorry for the delay... |
Hi @yann300 I'v putted dapp-template into remix codebase. Should I submit it in this PR? Or wait until you merge this one, and make another PR? |
apps/quick-dapp/src/components/MultipleContainers/components/Item/components/Remove/Remove.tsx
Outdated
Show resolved
Hide resolved
aab19f2
to
b2cdf46
Compare
Try it here -- https://remix-quick-dapp.vercel.app/
Here is the explanation for the references in code.
https://remix-dapp.pages.dev is the domain of the dapp template.
https://remix-dapp.pages.dev/manifest.json is the json file contains all the static files paths of dapp-template. It's generated through the build process automatically.
Before the dapp deployment, quick-dapp plugin will get all the static files paths of dapp-template, and download them from the dapp-template domain.
https://vercel-proxy-bice-six.vercel.app is the proxy to resolve the cross-domain issue. Because the backend service of surge does not support cross-domain.
Here is the codebase of the dapp-template https://github.com/drafish/remix-dapp
Here is the codebase of the proxy https://github.com/drafish/vercel-proxy
They are not in the remix codebase.
@ryestew