Hometab changes based on qa #4907

joeizang · 2024-06-19T13:50:02Z

Changes

Move ipfs and https buttons to file Explorer
change modal implementation for git clone
button text changes
remove responsiveness from gettingStarted and files section
adjust spacing around different elements

netlify · 2024-06-19T13:50:19Z

✅ Deploy Preview for remixproject ready!

Name	Link
🔨 Latest commit	`991c884`
🔍 Latest deploy log	https://app.netlify.com/sites/remixproject/deploys/667c191e89cbda000862af20
😎 Deploy Preview	https://deploy-preview-4907--remixproject.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Aniket-Engg · 2024-06-20T07:13:40Z

apps/remix-ide/src/app/tabs/locales/en/home.json

@@ -66,6 +66,8 @@
  "home.resources": "Resources",
  "home.connectToLocalhost": "Connect to Localhost",
  "home.seeAllTutorials": "See all tutorials",
-  "home.maintainedByRemix": "Maintained by Remix"
+  "home.maintainedByRemix": "Maintained by Remix",
+  "home.gitCloneTooltip": "Clone a github repo to a new workspace",


it should be GitHub

Aniket-Engg · 2024-06-20T07:14:12Z

libs/remix-ui/home-tab/src/lib/components/homeTabFile.tsx

@@ -299,24 +301,22 @@ contract HelloWorld {
                  />
                </span>
              </CustomTooltip>
-              <button className="btn text-nowrap p-2 mr-2 border my-1" onClick={() => showFullMessage('Ipfs', 'ipfs hash', ['ipfs://QmQQfBMkpDgmxKzYaoAtqfaybzfgGm9b2LWYyT56Chv6xH'], 'ipfs://')}>
+              {/* <button className="btn text-nowrap p-2 mr-2 border my-1" onClick={() => showFullMessage('Ipfs', 'ipfs hash', ['ipfs://QmQQfBMkpDgmxKzYaoAtqfaybzfgGm9b2LWYyT56Chv6xH'], 'ipfs://')}>


remove commented code

Aniket-Engg · 2024-06-20T07:14:20Z

libs/remix-ui/home-tab/src/lib/components/homeTabFile.tsx

-                  showFullMessage('Https', 'http/https raw content', ['https://raw.githubusercontent.com/OpenZeppelin/openzeppelin-contracts/master/contracts/token/ERC20/ERC20.sol'])
-                }
+              </button> */}
+              {/* <button className="btn text-nowrap p-2 mr-2 border my-1" data-id="landingPageImportFromGitHubButton" onClick={() => showFullMessage('GitHub', 'github URL', ['https://github.com/0xcert/ethereum-erc721/src/contracts/tokens/nf-token-metadata.sol', 'https://github.com/OpenZeppelin/openzeppelin-solidity/blob/67bca857eedf99bf44a4b6a0fc5b5ed553135316/contracts/access/Roles.sol'])}> */}


yann300 · 2024-06-20T08:07:09Z

libs/remix-ui/home-tab/src/lib/components/homeTabFile.tsx

+              <CustomTooltip placement={'top'} tooltipId="overlay-tooltip" tooltipClasses="text-nowrap" tooltipText={<FormattedMessage id="home.gistTooltip" />} tooltipTextClasses="border bg-light text-dark p-1 pr-3"
+              >
+                <button className="btn text-nowrap p-2 mr-2 border my-1" data-id="landingPageImportFromGistButton" onClick={() => importFromGist()}>
+                Open Gist Repo


why Open Gist repo?

This isn't a permanent change. I have reverted this back

ryestew · 2024-06-22T18:24:51Z

libs/remix-ui/home-tab/src/lib/components/homeTabGetStarted.tsx

  {
    gsID: 'sUTLogo',
    workspaceTitle: 'ERC20',
    description: 'Create a new ERC20 token using this template.',
    projectLogo: 'assets/img/oxprojectLogo.png',
    templateName: 'ozerc20',
  },
+  {
+    gsID: 'sUTLogo',
+    workspaceTitle: 'Uniswap V4 Basic',


I think this should be:
Uniswap v4 Hooks
because in the README.md in this template it says,"A template for writing Uniswap v4 Hooks"

ryestew · 2024-06-22T18:26:55Z

libs/remix-ui/home-tab/src/lib/components/homeTabGetStarted.tsx

    projectLogo: 'assets/img/remixverticaltextLogo.png',
    templateName: 'remixDefault',
  },
  {
    gsID: 'sUTLogo',
-    workspaceTitle: 'Circom',
+    workspaceTitle: 'Zk Semaphore',


Please make it:
ZK Semaphore
(capital K)

Aniket-Engg

there is no validation in import from https and import from IPFS form.

If I enter no url, click on Import, modal disappears and no info shown to user

Aniket-Engg

recent workspaces seems broken to me for workspace created using a template listed on home tab

joeizang · 2024-06-24T06:36:54Z

there is no validation in import from https and import from IPFS form.

If I enter no url, click on Import, modal disappears and no info shown to user

Ok

Aniket-Engg

If I click on NEW button from home tab, active plugin should be updated to file explorer

yann300 · 2024-06-24T08:15:38Z

In recent workspaces, it shows the last two worskpaces instead of the last 3 workspaces in live.

LianaHus · 2024-06-24T08:25:17Z

@joeizang are you aiming to close #4905 ?

joeizang · 2024-06-24T10:00:38Z

#4905

I will definitely look at the issue and have it closed if possible

LianaHus · 2024-06-25T08:38:53Z

libs/remix-ui/home-tab/src/lib/components/homeTabFile.tsx

-    return "Hello World!";
-  }
-}
+        pragma solidity >=0.6.12 <0.9.0;


this will be wrong in editor

I just pasted the code into the contract and it worked without any errors. Maybe you are referring to something else?

indentation will be wrong in remix editor

LianaHus · 2024-06-25T08:39:50Z

libs/remix-ui/home-tab/src/lib/components/homeTabFile.tsx

+                  _paq.push(['trackEvent', 'hometab', 'filesSection', 'Git Clone'])
+                  await plugin.call('filePanel', 'clone')
+                }}>
+                Git Clone


indentation

LianaHus · 2024-06-25T08:40:04Z

libs/remix-ui/home-tab/src/lib/components/homeTabFile.tsx

+              <CustomTooltip placement={'top'} tooltipId="overlay-tooltip" tooltipClasses="text-nowrap" tooltipText={<FormattedMessage id="home.gistTooltip" />} tooltipTextClasses="border bg-light text-dark p-1 pr-3"
+              >
+                <button className="btn text-nowrap p-2 mr-2 border my-1" data-id="landingPageImportFromGistButton" onClick={() => importFromGist()}>
+                Gist


joeizang requested a review from LianaHus June 19, 2024 13:50

joeizang self-assigned this Jun 19, 2024

Aniket-Engg reviewed Jun 20, 2024

View reviewed changes

yann300 reviewed Jun 20, 2024

View reviewed changes

joeizang force-pushed the hometab-qa-fixes branch 2 times, most recently from 614fd19 to 683eda6 Compare June 21, 2024 12:33

ryestew requested changes Jun 22, 2024

View reviewed changes

ryestew approved these changes Jun 24, 2024

View reviewed changes

Aniket-Engg requested changes Jun 24, 2024

View reviewed changes

Aniket-Engg reviewed Jun 24, 2024

View reviewed changes

joeizang requested a review from ryestew June 24, 2024 06:33

Aniket-Engg reviewed Jun 24, 2024

View reviewed changes

joeizang force-pushed the hometab-qa-fixes branch from b08cd74 to 8350970 Compare June 24, 2024 16:07

LianaHus reviewed Jun 25, 2024

View reviewed changes

joeizang added the translation label Jun 25, 2024

joeizang requested review from LianaHus, Aniket-Engg and yann300 June 25, 2024 11:23

LianaHus approved these changes Jun 26, 2024

View reviewed changes

joeizang added 4 commits June 26, 2024 19:05

changes based on qa

1bce5d6

change ai section text color. change text for tooltip

cdb65e6

add tooltip and translation

ef9f330

changes as per call with Liana

adeaec2

joeizang added 26 commits June 26, 2024 19:05

circom & uniswap button text updates

a4b3e0a

inject dependency for filePanel

b3523b5

adjust spacing

b8b8c54

remove console log

d19decc

fix props and icon classes

2a8fef0

responsive adjustments.

026b99c

move ipfs and https import buttons

49b857b

update modal state hiding

d00485f

cleanup console.log

7513b65

fix e2e

73ca67b

fix git clone e2e for hometab clean commented code.

c9d32da

clean unused code

5448844

fix e2e

fd620c5

address comments from @ryestew

840ff45

fix uniswap v4 description

010e0f3

Fix recent workspaces bug. Add validation to external import

ee2f972

fix niggly issues

16343e6

fix code formatting

80e5ed8

add padding to icons

952e631

update homeTabFile button. update image css and translation

6ede74c

fix css classes

cac8807

disable e2e for git clone button

977c71b

update css with flex-wrap

91073ae

restore git clone button

5fd0390

restore e2e for git clone

99daf03

switch git clone button icon

991c884

Aniket-Engg force-pushed the hometab-qa-fixes branch from 71dd68e to 991c884 Compare June 26, 2024 13:35

Aniket-Engg approved these changes Jun 26, 2024

View reviewed changes

Aniket-Engg merged commit 348e183 into master Jun 26, 2024
32 checks passed

Aniket-Engg deleted the hometab-qa-fixes branch June 26, 2024 16:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hometab changes based on qa #4907

Hometab changes based on qa #4907

joeizang commented Jun 19, 2024 •

edited

Loading

netlify bot commented Jun 19, 2024 •

edited

Loading

Aniket-Engg Jun 20, 2024

joeizang Jun 20, 2024

Aniket-Engg Jun 20, 2024

joeizang Jun 20, 2024

Aniket-Engg Jun 20, 2024

joeizang Jun 20, 2024

yann300 Jun 20, 2024

joeizang Jun 20, 2024

ryestew Jun 22, 2024

joeizang Jun 23, 2024

ryestew Jun 22, 2024

joeizang Jun 23, 2024

Aniket-Engg left a comment

Aniket-Engg left a comment

joeizang commented Jun 24, 2024

Aniket-Engg left a comment

yann300 commented Jun 24, 2024

LianaHus commented Jun 24, 2024

joeizang commented Jun 24, 2024

LianaHus Jun 25, 2024

joeizang Jun 25, 2024

LianaHus Jun 26, 2024

LianaHus Jun 25, 2024

joeizang Jun 25, 2024

LianaHus Jun 25, 2024

joeizang Jun 25, 2024

Hometab changes based on qa #4907

Hometab changes based on qa #4907

Conversation

joeizang commented Jun 19, 2024 • edited Loading

netlify bot commented Jun 19, 2024 • edited Loading

✅ Deploy Preview for remixproject ready!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Aniket-Engg left a comment

Choose a reason for hiding this comment

Aniket-Engg left a comment

Choose a reason for hiding this comment

joeizang commented Jun 24, 2024

Aniket-Engg left a comment

Choose a reason for hiding this comment

yann300 commented Jun 24, 2024

LianaHus commented Jun 24, 2024

joeizang commented Jun 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joeizang commented Jun 19, 2024 •

edited

Loading

netlify bot commented Jun 19, 2024 •

edited

Loading