FE Delete & Rename shortcut keys #4976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Aniket-Engg
reviewed
Jul 12, 2024
| @@ -97,6 +101,98 @@ export const FileExplorer = (props: FileExplorerProps) => { | |||
| } | |||
| }, [treeRef.current]) | |||
|
|
|||
| useEffect(() => { | |||
| const performDeleteion = async () => { | |||
| } | ||
| } | ||
| } | ||
| const deleteKeyPressUpHandler = async (eve: KeyboardEvent) => { |
There was a problem hiding this comment.
Why do you need to add listeners for both keyup & keydown?
There was a problem hiding this comment.
Yes, the keyUp updates the state variable for deleteKey and F2Key
| setState((prevState) => { | ||
| return { ...prevState, deleteKey: false } | ||
| }) | ||
| return |
There was a problem hiding this comment.
should performDeleteion() be called here too?
| @@ -357,6 +453,7 @@ export const FileExplorer = (props: FileExplorerProps) => { | |||
| } | |||
|
|
|||
| const handleTreeClick = (event: SyntheticEvent) => { | |||
| console.log({ props, state }) | |||
Aniket-Engg
reviewed
Jul 15, 2024
| if (treeRef.current) { | ||
| const deleteKeyPressHandler = async (eve: KeyboardEvent) => { | ||
| if (eve.key === 'Delete' ) { | ||
| (window as any)._paq.push(['trackEvent', 'fileExplorer', 'deleteKey']) |
There was a problem hiding this comment.
it will be better to create a variable for (window as any)
There was a problem hiding this comment.
also _paq.push takes 4 args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #258