show lines for warnings where available, in Solidity Scan report #4978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yann300
reviewed
Jul 15, 2024
| line: f.line_nos_end[0], | ||
| } | ||
| } | ||
| await plugin.call('editor', 'highlight', position) |
There was a problem hiding this comment.
at which point does this get unhighlighted?
There was a problem hiding this comment.
I have just added a commit to discard highlighting on multiple actions
There was a problem hiding this comment.
highlighting is removed
Aniket-Engg
force-pushed
the
posforGas
branch
3 times, most recently
from
cca2d8e to
912b652
Compare
LianaHus
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4967
It shows warning lines for
gasissues in the report