Show log in github from FE #4979
Conversation
yann300
commented
Jul 10, 2024
•
yann300
commented
- adds "Log in Github" to the File Explorer.
- the github user is synced through an app state
- tests are added to connect through the FE and disconnect
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I would suggest redesigning a bit: |
|
| @@ -52,6 +53,7 @@ export const GitHubCredentials = () => { | |||
| setGithubToken(credentials.token || '') | |||
| setGithubUsername(credentials.username || '') | |||
| setGithubEmail(credentials.email || '') | |||
| props.plugin.emit('loggedInGithubChanged') | |||
There was a problem hiding this comment.
no passing around plugin in props please.
There was a problem hiding this comment.
use plugin actions context
yann300
force-pushed
the
github_fe
branch
4 times, most recently
from
af8c99a to
b2a850e
Compare
There was a problem hiding this comment.
- It should not say
Login in with
- It looks like manually providing Github credentials never works and show error dialog in each case.
- It is better to tell what permissions are expected with token. I couldn't make this work.
- For logged in user, labels and details are not properly aligned, even if there are a great space available
- Labels are inconsistent saying
Gitfor username and email butGitHubfor token
|
@Aniket-Engg @yann300 please chip in on the topic Some answers and explanations:
what should it say? Sign in is better?
That is not true in my tests and is also included in e2e, it works when you provide a valid token with the correct permissions. The point is this a lot of instructions to give how to create a valid token. So where do we put it? in a popup? or a panel? where can we explain this?
Yes it's technically not available. Github only supplies the scopes of permissions of a token in the API when you log in with github. Not when you provide tokens you create yourself. Nothing I can do about it. So we can only check the permissions when you login in, not when it's manual. I wish it was different.
It looks the same as in any other part of remix UI with input fields. To my eyes 👁️
Yes that is on purpose. the username/email is a git setting, the token is only connected to github. the username/email is something you always need to do commits, and is git only. you can commit and do stuff if you have that filled in. the token is optional. |
|
|
Would be nice to
|
