Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readd and fix learneth #5017

Closed
wants to merge 1 commit into from
Closed

readd and fix learneth #5017

wants to merge 1 commit into from

Conversation

yann300
Copy link
Contributor

@yann300 yann300 commented Jul 17, 2024

This readd the learneth sectionin the homepage and fix a bug.

To reproduce the bug:

  • from the home page, start a tutorial.
  • from the homepage, select another tutorial.
  • the learneth iframe view is crashing.

The fix is just about not adding a repo if it's already present.

@yann300 yann300 added the ready-to-review PR ready to review label Jul 17, 2024
@yann300 yann300 requested a review from bunsenstraat July 17, 2024 11:57
Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 2d9b720
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/6697b2d02966e000088e6092
😎 Deploy Preview https://deploy-preview-5017--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yann300 yann300 force-pushed the learneth_homepage branch from 4f9fd07 to 2d9b720 Compare July 17, 2024 12:02
@Aniket-Engg
Copy link
Collaborator

Aniket-Engg commented Aug 15, 2024

As per the discussion, this will be done in a different way.

cc: @LianaHus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants