Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcut to copy and paste #5033

Merged
merged 18 commits into from
Aug 13, 2024
Merged

Conversation

joeizang
Copy link
Collaborator

@joeizang joeizang commented Jul 23, 2024

fixes #3309
This pr adds short cuts, Ctrl/Cmd + C, Ctrl/Cmd + X and Ctrl/Cmd + V to File Explorer

@joeizang joeizang added the WIP label Jul 23, 2024
@joeizang joeizang self-assigned this Jul 23, 2024
Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 4653e75
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/669fe45e1797f80008e99d21
😎 Deploy Preview https://deploy-preview-5033--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 4dc5f08
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/66bb258f20f9dd0008e47b3e
😎 Deploy Preview https://deploy-preview-5033--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joeizang joeizang added autorebase and removed WIP labels Jul 29, 2024
@github-actions github-actions bot force-pushed the fe-copycut-shortcutkeys branch 3 times, most recently from f997e13 to 0dc65b7 Compare July 30, 2024 07:09
@joeizang joeizang added ready-to-review PR ready to review and removed autorebase labels Jul 30, 2024
@LianaHus
Copy link
Collaborator

LianaHus commented Aug 7, 2024

doesn't work for me. ubuntu/chrome

@joeizang joeizang force-pushed the fe-copycut-shortcutkeys branch from d9ae11e to 2b707ab Compare August 7, 2024 20:29
@joeizang joeizang force-pushed the fe-copycut-shortcutkeys branch from de13bc8 to aca203c Compare August 12, 2024 08:26
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality wise it looks fine. e2e tests should be added, may be in another PR

@Aniket-Engg Aniket-Engg merged commit 5ec8e47 into master Aug 13, 2024
32 checks passed
@Aniket-Engg Aniket-Engg deleted the fe-copycut-shortcutkeys branch August 13, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve FE context menu
3 participants