Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace selection fixes #5129

Merged
merged 11 commits into from
Oct 7, 2024
Merged

Workspace selection fixes #5129

merged 11 commits into from
Oct 7, 2024

Conversation

joeizang
Copy link
Collaborator

fixes #4266

@joeizang joeizang added the WIP label Aug 26, 2024
@joeizang joeizang self-assigned this Aug 26, 2024
Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit c1f6b29
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/6703f5c2de48970008b172b8
😎 Deploy Preview https://deploy-preview-5129--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joeizang joeizang force-pushed the workspace-selection-fixes branch from cd89e1c to 61f47eb Compare August 26, 2024 11:50
@joeizang joeizang requested a review from Aniket-Engg August 27, 2024 14:46
@joeizang joeizang force-pushed the workspace-selection-fixes branch 2 times, most recently from 8c065ce to 6ad693b Compare August 28, 2024 13:19
@joeizang joeizang added ready-to-review PR ready to review and removed WIP labels Aug 29, 2024
<Dropdown.Item
onClick={() => {
switchWorkspace(LOCALHOST)
}}
>
{currentWorkspace === LOCALHOST ? (
<span>&#10003; localhost </span>
<span>&#10003; Connected to Local Filesystem </span>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change discussed?

@joeizang joeizang added WIP and removed ready-to-review PR ready to review labels Sep 2, 2024
@joeizang joeizang requested review from LianaHus and ryestew September 5, 2024 13:30
@joeizang joeizang force-pushed the workspace-selection-fixes branch 2 times, most recently from 6e4f0f3 to 2fda0e7 Compare September 26, 2024 17:19
@LianaHus
Copy link
Collaborator

could you please put a divider before the Connect in hamburger? and also please remove -create workspace- from the dropdown

@LianaHus LianaHus requested a review from Aniket-Engg October 7, 2024 12:55
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-10-07 at 7 44 37 PM

Apart from this tooltip issue, this looks fine

@Aniket-Engg Aniket-Engg removed the WIP label Oct 7, 2024
@Aniket-Engg Aniket-Engg force-pushed the workspace-selection-fixes branch from 2e2f4de to da97ba2 Compare October 7, 2024 14:43
@Aniket-Engg Aniket-Engg merged commit bcf6730 into master Oct 7, 2024
32 checks passed
@Aniket-Engg Aniket-Engg deleted the workspace-selection-fixes branch October 7, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Localhost workspace selection
3 participants