Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short description for settings -> general section #5159

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Conversation

Aniket-Engg
Copy link
Collaborator

Shorten the text under options and move more info under tooltip

This will give more exposure to other items below

Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit f985e26
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/66e2afd26bab420008b27bb8
😎 Deploy Preview https://deploy-preview-5159--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Aniket-Engg Aniket-Engg added the WIP label Sep 2, 2024
@Aniket-Engg Aniket-Engg changed the title Short description for settings Short description for settings -> general section Sep 4, 2024
@Aniket-Engg Aniket-Engg added ready-to-review PR ready to review and removed WIP labels Sep 4, 2024
@Aniket-Engg Aniket-Engg requested a review from yann300 September 5, 2024 09:11
@LianaHus
Copy link
Collaborator

LianaHus commented Sep 5, 2024

I would suggest

  • to remove the first alert.
  • to use same I icon everywhere. solidity, udapp and here . maybe somewhere else we have
  • @yann300 since you were initially against short texts please review as well

@Aniket-Engg
Copy link
Collaborator Author

I would suggest

  • to remove the first alert.
  • to use same I icon everywhere. solidity, udapp and here . maybe somewhere else we have
  • @yann300 since you were initially against short texts please review as well

I have updated the icons as per the comment @LianaHus

@Aniket-Engg Aniket-Engg merged commit f37a465 into master Sep 12, 2024
32 checks passed
@Aniket-Engg Aniket-Engg deleted the shortSetts branch September 12, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants