Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Explorer Fixes #5161

Merged
merged 21 commits into from
Sep 12, 2024
Merged

Template Explorer Fixes #5161

merged 21 commits into from
Sep 12, 2024

Conversation

joeizang
Copy link
Collaborator

@joeizang joeizang commented Sep 4, 2024

fixes #5088
fixes #5170

@joeizang joeizang added the WIP label Sep 4, 2024
@joeizang joeizang self-assigned this Sep 4, 2024
Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 76685ce
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/66e2fde3c569bb00087fdc69
😎 Deploy Preview https://deploy-preview-5161--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joeizang joeizang added ready-to-review PR ready to review and removed WIP labels Sep 5, 2024
@ryestew
Copy link
Collaborator

ryestew commented Sep 10, 2024

I'll make some text corrections - but

  1. Why are there 4 contracts for each of the OZ templates? The descriptions are slightly different from each other but the content - on a brief look is the same.
  2. The modal that used to be there to choose additional dependencies (like transferable or burnable) is gone. That is a loss. Could returning that be part of this PR? Or would that expand the scope of this PR too much?

@ryestew
Copy link
Collaborator

ryestew commented Sep 10, 2024

See these issues to check if either are in the scope of this PR:
#5171
#5170

@ryestew
Copy link
Collaborator

ryestew commented Sep 10, 2024

The descriptions of the templates need a bit editing - but do we need adjectives like "simple" or "standard"? (that's a writing style question)
And is the word "Interface" correct? These are describing conracts not interfaces - right? An interface is the scaffold of a contract. (this is a technical question)

@ryestew
Copy link
Collaborator

ryestew commented Sep 10, 2024

Once we figure out if we have too many contracts here - then I can make some edits to the text and I'll specify the exact text with capitalization.

@LianaHus
Copy link
Collaborator

@joeizang can you fix the order/name according to 3rd item in the issue?

@joeizang
Copy link
Collaborator Author

joeizang commented Sep 10, 2024

#5088

The wording "Create Using Template isn't possible because the word create is used as part of infrastructure. Too many e2es are failing and too many things break when I tried to make the change.

I have made the change in the order of menu items though

@LianaHus
Copy link
Collaborator

I don't get it. I'm talking about label not data-id or any other kind of keyword. Why it should ve relevant? If it is we are doing something wrong there

@@ -88,7 +88,7 @@ export const templates = (intl, plugin) => {
{
value: "ozerc20",
displayName: "ERC20",
description: "A standard interface for fungible tokens",
description: "A Standard Interface for fungible Tokens",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Standard Interface for Fungible Tokens

@Aniket-Engg Aniket-Engg merged commit bf94e63 into master Sep 12, 2024
32 checks passed
@Aniket-Engg Aniket-Engg deleted the template-explorer-fixes branch September 12, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Blank Template: Modal always says its named blank-1 Templates plugin
4 participants