Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Circuit compiler actions #5238

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

azarpoor
Copy link

  • improve coding structure of circuit compiler actions
  • make it more readable
  • remove some additional codes
  • improve error handling

Copy link

netlify bot commented Sep 30, 2024

👷 Deploy request for remixproject pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ddf1d8a

@azarpoor
Copy link
Author

azarpoor commented Sep 30, 2024

@joeizang @yann300

Comment on lines -11 to -13
} else {
console.log('Existing circuit compilation in progress')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9 - !==

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey thank you i correct this check

@azarpoor azarpoor requested a review from dIvaD8 October 1, 2024 12:55
@azarpoor
Copy link
Author

azarpoor commented Oct 3, 2024

@bunsenstraat

@Aniket-Engg Aniket-Engg force-pushed the refact/circuit-compiler-actions branch from e0c0437 to 47cfe4d Compare December 9, 2024 10:36
@Aniket-Engg Aniket-Engg requested review from ioedeveloper and removed request for dIvaD8 December 9, 2024 10:36
@AmirH-A AmirH-A force-pushed the refact/circuit-compiler-actions branch from 47cfe4d to 54fa591 Compare December 9, 2024 15:29
@AmirH-A
Copy link

AmirH-A commented Dec 9, 2024

hello hope your doing well ,

Aniket-Engg

i have primary account which is this account with name AmirH-A

i change the auther to this account , and if its needed to change commiter to this also i don't know

i wanna mention this to you , thank you by the way

@ioedeveloper
Copy link
Member

@AmirH-A Can you rebase and fix the merge conflict?

@AmirH-A
Copy link

AmirH-A commented Dec 17, 2024

@AmirH-A Can you rebase and fix the merge conflict?

hey , yes of course

@AmirH-A
Copy link

AmirH-A commented Dec 17, 2024

@ioedeveloper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants