Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yul: Avoid expensive operations in functions called very often #15574

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Yul: Avoid expensive operations in functions called very often #15574

merged 2 commits into from
Nov 20, 2024

Commits on Nov 20, 2024

  1. Yul: Avoid expensive check in frequently called function 

    The equality comparison is called very often in
CommonSubexpressionEliminator, presumably because it is the comparison
operator used for the map
`CommonSubexpressionEliminator::m_replacementCandidates`.
The method `validLiteral` is nontrivial and should not be called
(twice!) on every call to the equality comparison.
    @blishko
    blishko committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    8548a93 View commit details
    Browse the repository at this point in the history

  2. Yul: Avoid expensive check against std::regex when possible

    @blishko
    blishko committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    5150015 View commit details
    Browse the repository at this point in the history