feat: update beacon jsonrpc endpoints #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
requested review from
KolbyML,
morph-dev and
ogenev
and removed request for
KolbyML and
morph-dev
KolbyML
approved these changes
Dec 10, 2024
looks good
trin-beacon/src/jsonrpc.rs
Outdated
| Some(client) => { | ||
| let update = client.get_finality_update().await; | ||
| match update { | ||
| Ok(update) => Ok(json!((update))), |
There was a problem hiding this comment.
Suggested change
| Ok(update) => Ok(json!((update))), | |
| Ok(update) => Ok(json!(update)), |
isn't this extra bracket redundent?
trin-beacon/src/jsonrpc.rs
Outdated
| Some(client) => { | ||
| let update = client.get_optimistic_update().await; | ||
| match update { | ||
| Ok(update) => Ok(json!((update))), |
There was a problem hiding this comment.
Suggested change
| Ok(update) => Ok(json!((update))), | |
| Ok(update) => Ok(json!(update)), |
isn't this extra bracket redundent?
ogenev
approved these changes
Dec 11, 2024
ethportal-api/src/beacon.rs
Outdated
| @@ -60,6 +64,14 @@ pub trait BeaconNetworkApi { | |||
| #[method(name = "beaconFinalizedHeader")] | |||
| async fn finalized_header(&self) -> RpcResult<BeaconBlockHeader>; | |||
|
|
|||
| /// Get the finality update | |||
There was a problem hiding this comment.
Suggested change
| /// Get the finality update | |
| /// Get the latest finality update |
ethportal-api/src/beacon.rs
Outdated
| #[method(name = "beaconFinalityUpdate")] | ||
| async fn finality_update(&self) -> RpcResult<LightClientFinalityUpdate>; | ||
|
|
||
| /// Get the optimistic update |
There was a problem hiding this comment.
Suggested change
| /// Get the optimistic update | |
| /// Get the latest optimistic update |
rpc/src/beacon_rpc.rs
Outdated
| @@ -116,6 +120,18 @@ impl BeaconNetworkApiServer for BeaconNetworkApi { | |||
| Ok(proxy_to_subnet(&self.network, endpoint).await?) | |||
| } | |||
|
|
|||
| /// Get the optimistic update. | |||
There was a problem hiding this comment.
Suggested change
| /// Get the optimistic update. | |
| /// Get the latest optimistic update. |
rpc/src/beacon_rpc.rs
Outdated
| Ok(proxy_to_subnet(&self.network, endpoint).await?) | ||
| } | ||
|
|
||
| /// Get the finality update. |
There was a problem hiding this comment.
Suggested change
| /// Get the finality update. | |
| /// Get the latest finality update. |
njgheorghita
force-pushed
the
beacon-api
branch
from
1de23c3 to
ba4bd23
Compare
carver
added a commit
to carver/trin
that referenced
this pull request
Dec 11, 2024
The only change is the new beacon endpoints merged in e18427e via ethereum#1604
carver
added a commit
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Exposing the updates rather than the headers themselves is more useful for displaying information in
trin-desktop.How was it fixed?
To-Do