docs: publishing ethportal-api, plus a Cargo.lock bump #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
approved these changes
Dec 12, 2024
looks good
Comment on lines
36
to
37
| [StackOverflow | ||
| post](https://stackoverflow.com/questions/79276315/how-to-build-a-cargo-lock-file-for-a-package-within-a-workspace). |
There was a problem hiding this comment.
Suggested change
| [StackOverflow | |
| post](https://stackoverflow.com/questions/79276315/how-to-build-a-cargo-lock-file-for-a-package-within-a-workspace). | |
| [StackOverflow post](https://stackoverflow.com/questions/79276315/how-to-build-a-cargo-lock-file-for-a-package-within-a-workspace). |
It is a little weird that these are on 2 different lines
There was a problem hiding this comment.
Yeah, vim just did that with gqq, but I don't mind manually changing it
It was publishing with the main trin readme
carver
added a commit
to carver/trin
that referenced
this pull request
Dec 12, 2024
- not every release is a prerelease, now, so update version guidance - add ethportal-api release instructions - don't rebase local master before tagging release If you have commits on your local master branch, rebasing would tag them into the release, bypassing the standard PR process.
carver
force-pushed
the
ethportal-api-publishing
branch
from
81cd11d to
2bc63bf
Compare
- not every release is a prerelease, now, so update version guidance - add ethportal-api release instructions - don't rebase local master before tagging release If you have commits on your local master branch, rebasing would tag them into the release, bypassing the standard PR process.
carver
force-pushed
the
ethportal-api-publishing
branch
from
2bc63bf to
c93e129
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.