fix: trin cli flag displays wrong version info #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
version
branch
2 times, most recently
from
4738f4e to
85537af
Compare
njgheorghita
changed the title
njgheorghita
force-pushed
the
version
branch
from
85537af to
c642307
Compare
njgheorghita
requested review from
morph-dev,
carver and
KolbyML
and removed request for
morph-dev and
carver
KolbyML
approved these changes
Dec 22, 2024
There was a problem hiding this comment.
we can do this for now if it is blocking anything.
I want to remove the shadow-rs stuff and replace it with a different solution as I don't think shadow-rs is needed to properly do versioning.
I also figured out how to make it so we report the right version for Trin which is nice. It is a little to much to discuss on this PR, but I need it for ping extensions. So I will probably make a PR after this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
#1581 (comment)
How was it fixed?
After a little research into our options, I agree with @carver 's suggestion to just remove the version dependency inside
ethportal-api. There might be an option with configuring thePROJECT_ROOTbased on a flag, but that route introduces some management overhead that IMO is not worthwhile. This solution plays nicely with docker and all our current config (afaik)... and I'm not sure it's a huge loss to remove theVERSIONinfo from the cli. The only side affect that I can tell is that runningwill just return the string I replaced the version with, and if somebody needs to know the version, running the client quickly seems like a reasonable compromise.
To-Do