Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Liquifier Size #152

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Reduce Liquifier Size #152

merged 3 commits into from
Aug 29, 2024

Conversation

jtfirek
Copy link
Contributor

@jtfirek jtfirek commented Aug 28, 2024 •
edited
Loading

  • Reduces the liquifier size to 23,052 resulting in a 1,524 margin under the size limit
  • Removes all of the logic and tests related to accepting assets restaked in EL
  • Removes the totalDeposit calculation. It is unused on-chain and can be obtained through iterating over events if we need the value off-chain
  • There is still a bunch of unused cbETH and wbETH logic, but I opted to leave as it to make this pr less invasive

Unrelated, but when we start working on protocol V3, I would like to migrate this logic to a new contract written from scratch

@jtfirek jtfirek requested a review from seongyun-ko August 28, 2024 19:18
seongyun-ko
seongyun-ko approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@seongyun-ko seongyun-ko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM. can you update Certora team that we deprecated these?

@jtfirek jtfirek merged commit 89b8462 into staging-2.5 Aug 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seongyun-ko seongyun-ko seongyun-ko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtfirek @seongyun-ko