Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Certora][L-04] Check for duplicates in pausable array #174

Merged
merged 1 commit into from
Nov 11, 2024
Merged

[Certora][L-04] Check for duplicates in pausable array #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Pauser.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@ contract Pauser is Initializable, UUPSUpgradeable, OwnableUpgradeable {
* @notice Adds a contract to the list of pausables.
*/
function addPausable(IPausable _pausable) external onlyRole(PAUSER_ADMIN) {
for (uint256 i = 0; i < pausables.length; ++i) {
if (address(pausables[i]) == address(_pausable)) {
revert("Contract already in pausables");
}
}
pausables.push(_pausable);
emit PausableAdded(address(_pausable));
}
Expand Down
9 changes: 9 additions & 0 deletions test/Pauser.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,13 @@ contract PauserTest is TestSetup {
vm.expectRevert("Sender requires permission");
pauserInstance.pauseSingle(IPausable(address(liquidityPoolInstance)));
}

function test_pushDuplicate() public {
vm.expectRevert("Contract already in pausables");
pauserInstance.addPausable(IPausable(address(liquidityPoolInstance)));

pauserInstance.removePausable(0);

pauserInstance.addPausable(IPausable(address(liquidityPoolInstance)));
}
}
Loading