[Certora] [M-10] + [M-11] Manual tracking of EETH shares owned by membership manager #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seongyun-ko
reviewed
Oct 7, 2024
| eETH.transfer(msg.sender, totalBalance - feeAmount); | ||
|
|
||
| if (feeAmount > 0) { | ||
| liquidityPool.withdraw(address(this), feeAmount); | ||
| uint256 feeShares = liquidityPool.withdraw(address(this), feeAmount); |
There was a problem hiding this comment.
By this withdraw, the membership manager contract will receive ETH (not eETH), which is used to boost the MembershipNFT APR when rebasing happens. so it should not be counted as membershipShares
- ETH balance in MembershipManager https://etherscan.io/address/0x3d320286E014C3e1ce99Af6d6B00f0C1D63E3000
seongyun-ko
requested changes
Oct 7, 2024
There was a problem hiding this comment.
LGTM overall, but left a feedback on one fix
A few points to confirm:
- is the contract size below the limit?
- isnt' there any change required here? https://github.com/etherfi-protocol/smart-contracts/blob/audit-m10-m11/src/libraries/GlobalIndexLibrary.sol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a manual tracking for the number of EETH shares owned by the membership manager. This prevents anyone from being able to impact rebasing operations via donating eETH shares to the membership manager
Primary testing provided by the existing
test_bring_random_monkeys()function. At the conclusion of this function with thousands of deposit / rebase / withdrawal operations, shares are within 5000 shares of the target amount which is just dust.