fix: redundancy root push #4711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldeffenb
reviewed
Jun 13, 2024
| @@ -31,9 +31,9 @@ func NewPutter(p storage.Putter) storage.Putter { | |||
| // Put makes the getter satisfy the storage.Getter interface | |||
| func (p *putter) Put(ctx context.Context, ch swarm.Chunk) (err error) { | |||
| rlevel := redundancy.GetLevelFromContext(ctx) | |||
| errs := []error{p.putter.Put(ctx, ch)} | |||
| errs := []error{} | |||
There was a problem hiding this comment.
Ah, so THIS is where the redundant put of the root chunk came from? I was wondering! Do you mind my asking (for my own education) where the root chunk actually gets put for rlevel==0?
There was a problem hiding this comment.
it is done by the hashtrie module which is in a chunk pipeline process that has a ChainWrite function which does the job.
zelig
approved these changes
Jun 15, 2024
martinconic
approved these changes
Jul 1, 2024
acha-bill
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4705
Checklist
Description
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):