Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract label-selector as a flag for node-funder and operator #411

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

gacevicljubisa
Copy link
Contributor

@gacevicljubisa gacevicljubisa commented Aug 23, 2024

Refactor: Extract label-selector as a flag with default beekeeper.ethswarm.org/node-funder=true.

  • Introduced a flag to specify the label selector for K8S resources used by node-funder and operator.
  • Default label selector set to beekeeper.ethswarm.org/node-funder=true.
  • If the label selector is an empty string, no filtering is applied.
  • The label selector works in conjunction with the namespace for more granular resource selection.

@gacevicljubisa gacevicljubisa requested a review from vandot August 23, 2024 15:39
@gacevicljubisa gacevicljubisa changed the title fix(node-funder): extract label-selector as a flag refactor(node-funder): extract label-selector as a flag Aug 23, 2024
Copy link

@darkobas2 darkobas2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be installed in-cluster or no ? so why ingress ?
in cluster communication should go via services

@gacevicljubisa
Copy link
Contributor Author

gacevicljubisa commented Oct 2, 2024

This should be installed in-cluster or no ? so why ingress ? in cluster communication should go via services

@darkobas2 node-funder is not meant to work in-cluster only, but the operator feature is meant to work in-cluster. I will adapt that as well to use the same label selector as default, but with the option to explicitly set it. Thank you for the comment.

@gacevicljubisa gacevicljubisa changed the title refactor(node-funder): extract label-selector as a flag refactor: extract label-selector as a flag for node-funder and operator Oct 2, 2024
@darkobas2 darkobas2 merged commit 8d0a18f into master Oct 2, 2024
3 checks passed
@darkobas2 darkobas2 deleted the node-funder branch October 2, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants