Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

TestDeploy magical constant for initial deposit #1928

Closed
Eknir opened this issue Nov 5, 2019 · 1 comment · Fixed by #2061
Closed

TestDeploy magical constant for initial deposit #1928

Eknir opened this issue Nov 5, 2019 · 1 comment · Fixed by #2061
Labels
incentives priority test

Comments

@Eknir
Copy link
Contributor

Eknir commented Nov 5, 2019

Currently, the function testDeploy uses a magical constant for the initial deposit:

	opts.Value = big.NewInt(9000 * int64(RetrieveRequestPrice))

We need to make this value parametrizable for testDeploy in order to prevent cheques from being bounced and make other tests not dependable on changing this constant.
@mortelli mortelli added the test label Nov 5, 2019
@mortelli
Copy link
Contributor

mortelli commented Nov 5, 2019

should solve one of the pending issues in #1925

@ralph-pichler ralph-pichler mentioned this issue Dec 20, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
incentives priority test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

swap: pass depositAmount to testDeploy ethersphere/swarm
2 participants
@mortelli @Eknir