This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
swap: pass depositAmount to testDeploy #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortelli
approved these changes
Dec 20, 2019
holisticode
reviewed
Dec 23, 2019
holisticode
approved these changes
Dec 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the magical deployment deposit constant and lets each call of testDeploy decide the value individually. Deposits where chosen to the minimum amount required in each test.
To make things easier this PR also changes the way test deposits are made. Previously they were funded by the swap owner address (requiring token prefunding of that account also). Now they are always minted on demand by the token owner (the global
ownerKey).closes #1928