-
Notifications
You must be signed in to change notification settings - Fork 110
network/simulation: Basic bootnode support + expanded enode.ID exclusion #1799
base: master
Are you sure you want to change the base?
network/simulation: Basic bootnode support + expanded enode.ID exclusion #1799
Conversation
@chadsr I'm not sure the PR to the main ethereum repo is necessary. If anything, we should just PR into our Please when you move stuff out of Thanks! |
@acud Makes sense. I'm happy to prepare said PRs and see if that's the general consensus. I'll then just rebase this PR to the migration. Thanks for the feedback! |
@acud After the input from fjl at go-ethereum, I figured this PR is still the best path to go? |
26abce5
to
2655c10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few minor comments.
also: travis is red
2655c10
to
f82120d
Compare
Also in regards to the failing build, this is still reliant on a go-ethereum PR which was just merged into master. |
Thanks for taking care of this PR @chadsr. |
There are build failures:
|
@janos This is due to what I mentioned above about depending on a new go-ethereum release. |
f82120d
to
820b66c
Compare
Note: This PR is dependent on this go-ethereum PR.
NodeConfig.BootNode
flag. (Lightnode support was omitted since it will soon be deprecated in Swarm)