This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
network/kademlia: Prioritize closest peer when suggesting peer for neighborhood #1918
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in https://github.com/nolash/SWIPs/blob/hive/SWIPs/swip-hive.md, when suggesting peers, if unconected peers in the neighborhood, it should always prioritize connecting to the closest neighbor, e.g
In this situation , although bin0 is shallower, since both bin1 and bin0 are in the neighborhood, the suggested peer should be for bin1 (closest neighbor)
This PR modifies kademlia SuggestPeers method in order to prioritize connecting to the closest neighbor.
TestSuggestPeer has also been modified to explicitly test this behavior
Fixes #1897