Add build tests for different ROS versions #24
Conversation
This commit adds a github actions to verify builds for ROS Noetic and ROS Melodic
|
The CI runs on my fork, but not here: Jaeyoung-Lim#1 @floriantschopp Is the repo somehow configured not to run github actions? |
There was a problem hiding this comment.
@Jaeyoung-Lim Thanks for adding this. I am new to GitHub releases, so not much experience there. Since VersaVIS depends on a lot more than just a successful build of the ROS packages, adding such tests was quite low priority. But it also can't hurt :-)
.github/workflows/build_test.yml
Outdated
| - {rosdistro: 'melodic', container: 'px4io/px4-dev-ros-melodic:2020-08-14'} | ||
| - {rosdistro: 'noetic', container: 'px4io/px4-dev-ros-noetic:2020-08-20'} |
There was a problem hiding this comment.
could we also use a standard repo here instead px4io?
There was a problem hiding this comment.
Yeap, I think that makes more sense
| push: | ||
| branches: | ||
| - 'master' | ||
| pull_request: | ||
| branches: | ||
| - '*' |
There was a problem hiding this comment.
Are there also nightly tests?
There was a problem hiding this comment.
I think we should add this, then I am fine for trying that change...
There was a problem hiding this comment.
Done! I have configured it to run 18:00 UTC everyday
Jaeyoung-Lim
force-pushed
the
pr-github-actions
branch
from
2e0cbc6 to
a655fa9
Compare
This commit runs nightly builds everyday at 18:30 UTC
Jaeyoung-Lim
force-pushed
the
pr-github-actions
branch
from
4975a51 to
6f223c8
Compare
|
@floriantschopp Can we enable github actions for this repo? Then I can also add build status badges to the readme in this PR |
Jaeyoung-Lim
force-pushed
the
pr-github-actions
branch
from
864fbf7 to
b18091e
Compare
Problem Description
This commit adds a simple build test for the following ROS versions
Additional Context