Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inputs and outputs to the graph #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

trams
Copy link
Contributor

@trams trams commented Feb 13, 2017

This is an attempt to show inputs and outputs in the flow diagram.

It is not very pretty. For one I didn't add any pictures for sources and sinks.
Also it contains a hack to filter __pipeX__pipeY outputs which may not work on your cluster

Apart from this it works perfectly and makes the diagram much more useful, especially for one step jobs.

Change-Id: Id153bf3975a304047e574b57fd66399c227aaf04
@dossett
Copy link
Contributor

dossett commented Apr 20, 2017

@trams Thank you for your many recent PRs! I merged a couple of them already, and will come back to the others after we get 1.1 released.

@trams
Copy link
Contributor Author

trams commented Apr 20, 2017

@dossett thanks! I'll wait for 1.1 and then try to rebase

@nixsticks
Copy link
Contributor

nixsticks commented Jul 7, 2017

Hey @trams, thank you for all the contributions you've made! This is a great idea but I'm hesitant because it makes graphs of moderate or larger size look quite unwieldy. If you have thoughts on how to improve the UX on that, we'd love to hear them.

@trams
Copy link
Contributor Author

trams commented Jul 7, 2017

Just out of curiosity what is the size of moderate graph? Most of our jobs contain around 3-5 steps and it look okayish (I didn't look for a proper picture for input|output)

@nixsticks
Copy link
Contributor

nixsticks commented Jul 7, 2017

@trams Many of our jobs are much larger than yours it sounds like -- a moderately-sized one would be around 10-15 steps for us(!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants