This repository has been archived by the owner on Aug 30, 2024. It is now read-only.
UserData Testcase #232
Open
UserData Testcase #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erdata to euinstance.py
| For aesthetics, the user data value is a 16K file thats converted to string then compare, | ||
| """ | ||
| if self.user_data_file: | ||
| with open(self.user_data_file) as user_data_file: |
There was a problem hiding this comment.
Can we generate the 16K on the fly rather than adding a static file? You should be able to use self.tester.id_generator(16000)
| @@ -55,6 +55,9 @@ def __init__( self, name="InstanceBasics", credpath=None, region=None, config_fi | |||
| self.address = None | |||
| self.volume = None | |||
| self.private_addressing = False | |||
| if not user_data: | |||
| ### Set userdata string to 16K to test max string size for userdata | |||
| self.user_data = self.tester.id_generator(16000) | |||
There was a problem hiding this comment.
@hspencer77 I believe this change will break some test scenarios. Specifically when no user data is set we send a user data that enables root login.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added UserData test to instancetest.py. The purpose of this test is to confirms if the userdata service is working correctly, and tests to make sure userdata of 16K size is accepted, per AWS spec.