Implement a simple pause / resume #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Sorry for totally missing the notification for this PR. From a quick glance your PR only stops keyword emission, which might lead to unexpected results. For example calling pause() in the middle of an utterance won't stop the audio stream from being set to the speech provider and detection will run until the end of the utterance. I think the "right" way to solve this is to mute the hardware device or the audio stream that being consumed by Sonus. Going to keep this PR open, in case it helps anyone, at least until I manage to get around to fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
I have implemented a simple
pause()andresume()methods to have a solution to the issue that I met with the orginal methods (#95)