added lgess15 support #17432
Open
added lgess15 support #17432
+152
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texperiri
force-pushed
the
feat/lgess15
branch
from
1ca7f77
to
253a35e
Compare
|
this enhancement has not yet been tested live on an ESS HOME 15 |
|
Thank you for the PR (and creative use of generics)! I think we could still make this a little more elegant- if your want? |
andig
reviewed
Nov 25, 2024
| } | ||
|
|
||
| // read data from Lgess, reconnects if session expired | ||
| func refreshDataFromLgess[T MeterResponse8 | MeterResponse15](meterResponse *T, m *Com) error { |
There was a problem hiding this comment.
How about
func (m *Com) refresh(res any) error
and then call it with
var res EssData8
err := m.refresh(&res)
| res.GridPower = -res.GridPower | ||
| // convert response from LgEss8/10 into interface EssData | ||
| func essDataFromMeterResponse8(essData *EssData, meterResponse *MeterResponse8) { | ||
| essData.GridPower = meterResponse.Statistics.GridPower |
There was a problem hiding this comment.
This feels a bit awkward. An alternative would be to make EssData8 and EssData15 implement a common interface?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new template for the lg-ess-home-15 type
Adapted meters/lgess and lgpcs to be able to differ between lg-ess-home-8-10 and lg-ess-home-15 because lg-ess-home-15 provides different content in the json data.