DEVPROD-6193 Use IRSA to sign mciuploads bucket urls #8566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for the bucket as well
ZackarySantana
changed the title
ZackarySantana
changed the title
ablack12
reviewed
Dec 19, 2024
model/artifact/artifact_file.go
Outdated
| catcher.ErrorfWhen(f.FileKey == "", "file key is required") | ||
|
|
||
| if f.Bucket != "mciuploads" { | ||
| catcher.ErrorfWhen(f.AwsKey == "", "aws key is required") |
ybrill
reviewed
Dec 19, 2024
|
Once approved, going to get an LGTM to add the corresponding field to production |
ybrill
reviewed
Dec 20, 2024
ablack12
reviewed
Dec 26, 2024
agent/command/s3_put.go
Outdated
| @@ -125,7 +125,8 @@ type s3put struct { | |||
| isPatchable bool | |||
| isPatchOnly bool | |||
|
|
|||
| bucket pail.Bucket | |||
| bucket pail.Bucket | |||
| devprodOwnedBuckets []string | |||
There was a problem hiding this comment.
could we call this like, internalBuckets or something? Just for future proofing, what if we aren't "DevProd" forever haha (think "mci")
…from devprod owned buckets
ablack12
approved these changes
Jan 2, 2025
ybrill
reviewed
Jan 2, 2025
| @@ -1906,7 +1902,7 @@ <h2 class="modal-title">[[modalTitle]]</h2> | |||
| <input type="text" ng-model="Settings.providers.aws.task_sync_read.secret"> | |||
| </md-input-container> | |||
| <md-input-container class="control" style="width:45%;"> | |||
| <label>Task Read-Only S3 Bucket</label> | |||
| must be specified<label>Task Read-Only S3 Bucket</label> | |||
There was a problem hiding this comment.
this seems like it was meant to be somewhere else
Comment on lines
33
to
+36
|
|
||
| // InternalBuckets are the buckets that Evergreen's app servers have access to | ||
| // via their IRSA role. | ||
| InternalBuckets []string `yaml:"internal_buckets" bson:"internal_buckets" json:"internal_buckets"` |
There was a problem hiding this comment.
The way BucketsConfig is structured now this seems out of place. Like before the Credentials field contains the credentials for accessing the LogBucket. But now the InternalBuckets are interjected in the middle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-6193
Description
This makes the app servers use AWS IRSA to sign mciuploads bucket urls and it also stops uploading the keys when a user uploads to mciuploads.
Testing
Deployed in staging. Added the new key in staging global document. This task uploaded a signed url, and it generates the url correctly and the database does hold the key/secret that was associated with it but the generated url is without it.