DEVPROD-7289 Resolve symlinks and links correctly when extracting tarballs #8574
+201
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
it looks like there's a security risk involved with using absolute paths because it could potentially be abused by symlinking something they shouldn't have access to (that's what I'm assuming) should we still do this then? |
This reverts commit 7d31bff.
|
Hm, if it tried symlinking something they shouldn't have access to it would get permission denied. The agent app has the same permission as the user / vice versa. The issue that was lately was what you described but unintentional (it was symlinking to /<arfiact_file> rather than /<task_dir>/<artifact_file> |
|
Let me try out the security suggestion the code quality says (I think it is a non-problem but it can't hurt!) |
bynn
approved these changes
Dec 20, 2024
ZackarySantana
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-7289
Description
This switches over to using the absolute path when extracting files
Testing
Old task has a tarball with the symlink file, the symlinked file (original) and tries to extract it. It fails with permission denied.
New tasks has two, one with it incorrectly set up with only the symlinked file (original) in the tarball, and one with it correctly with the symlink file and the symlinked file (original) which passes.