This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-4798 remove ssh key field #2324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ybrill this repo is now deprecated and all UI development happens in evergreen-ci/UI. Could you reopen this PR there? |
|
Oh wow. Sure thing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-4798
Description
evergreen-ci/evergreen#7713 removes the ssh key field from distros and also from the admin config. This PR will remove it from Spruce as well.
I'm not 100% sure how to coordinate the merging/deploys of these. Does the Spruce change go first and then the Evergreen one? But wouldn't a distro update break without the mandatory ssh key field? But if Evergreen goes first it won't be providing the required field. 😕
Also, why were there so many unrelated changes when I ran codegen? Has it just not been run in a while?
Screenshots
Testing
Seems to still work locally.
Evergreen PR
evergreen-ci/evergreen#7713