ETD-413-connectors-fee - after 1st code review

everytrade-io · Apr 14, 2022 · b21b7ce · b21b7ce
1 parent d6bab30
commit b21b7ce
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/plugin-base/src/main/java/io/everytrade/server/parser/exchange/XChangeApiTransaction.java b/plugin-base/src/main/java/io/everytrade/server/parser/exchange/XChangeApiTransaction.java
@@ -39,7 +39,7 @@ public class XChangeApiTransaction {
     BigDecimal price;
     BigDecimal feeAmount;
     String address;
-    Boolean isBittrexApiDepositTx;
+    Boolean logIgnoredFees;
 
     public static XChangeApiTransaction fromTrade(UserTrade trade) {
         final Instrument instrument = trade.getInstrument();
@@ -113,7 +113,7 @@ public TransactionCluster toTransactionCluster() {
         }
 
         if (isIgnoredFee) {
-            if(isBittrexApiDepositTx) {
+            if(!logIgnoredFees) {
                 // ignore - Bittrex does not send any data for deposit fees because the deposit is free of charge.
             } else {
                 cluster.setIgnoredFee(1, "Fee " + (feeCurrency != null ? feeCurrency.code() : "null") + " currency is not base or quote");

diff --git a/...ase/src/main/java/io/everytrade/server/plugin/impl/everytrade/XChangeConnectorParser.java b/...ase/src/main/java/io/everytrade/server/plugin/impl/everytrade/XChangeConnectorParser.java
@@ -81,7 +81,7 @@ protected List<TransactionCluster> bittrexDepositsToCluster(List<BittrexDepositH
                     .quote(null)
                     .originalAmount(d.getQuantity())
                     .address(d.getCryptoAddress())
-                    .isBittrexApiDepositTx(true)
+                    .logIgnoredFees(false)
                     .build();
                 return xchangeApiTransaction.toTransactionCluster();
             } catch (Exception e) {