Merge pull request #1862 from evidence-dev/04-08-24-release

04 08 24 release
evidence-dev · Apr 8, 2024 · 113d4f7 · 113d4f7
2 parents a036129 + f87a122
commit 113d4f7
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 3 deletions.
diff --git a/.changeset/chilly-ladybugs-doubt.md b/.changeset/chilly-ladybugs-doubt.md
@@ -0,0 +1,5 @@
+---
+'@evidence-dev/core-components': patch
+---
+
+Fix for bigvalue loaded is undefined
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -1,7 +1,7 @@
 name: Tests
 
 on:
-  pull_request:
+  pull_request_target:
 
 jobs:
   Tests-sources:

diff --git a/.github/workflows/ui-tests.yml b/.github/workflows/ui-tests.yml
@@ -18,7 +18,7 @@ jobs:
           ref: ${{ github.event.pull_request.head.sha || github.sha }}
           checkName: 'Pages changed'
       - name: Wait for preview-deployment
-        uses: josephduffy/wait-for-netlify-action@v1.4
+        uses: archiewood/wait-for-netlify-action@v1
         id: waitForNetlifyPreviewDeployment
         with:
           site_name: evidence-development-workspace

diff --git a/packages/ui/core-components/src/lib/unsorted/viz/core/BigValue.svelte b/packages/ui/core-components/src/lib/unsorted/viz/core/BigValue.svelte
@@ -59,6 +59,7 @@
 			max-width: ${$$props.maxWidth};
 		`}
 		slot="skeleton"
+		let:loaded
 	>
 		<p class="text-sm text-gray-700">{$$props.title ?? ' '}</p>
 		<Value column={$$props.value} fmt={$$props.fmt} data={loaded} />

diff --git a/sites/docs/docs/markdown/index.md b/sites/docs/docs/markdown/index.md
@@ -159,7 +159,7 @@ You can put whatever data you would like here, and it uses a [yaml syntax](https
 | `og.description` | changes the body of the embed                                                                                                |
 | `og.image`       | will appear in the embed if specified, but it is not required.                                                               |
 | `queries`        | references SQL queries stored in the /queries directory.                                                                     |
-| `side_bar_position`        | changes the position of the page in the sidebar. When used in index.md pages, changes the position of their parent in the sidebar.                                                                     |
+| `sidebar_position`        | changes the position of the page in the sidebar. When used in index.md pages, changes the position of their parent in the sidebar.                                                                     |
 | `sidebar_link`        | when set to false, no link to the page appears in the sidebar. When used in index.md pages, the parent directory will still appear in the sidebar but it will not function as a link.                                                                    |