Merge pull request #2301 from evidence-dev/feat/dropdown-overhaul

Rewrite Dropdown
evidence-dev · Aug 15, 2024 · bd93a8f · bd93a8f
2 parents ec2934e + c24f8ad
commit bd93a8f
Show file tree

Hide file tree

Showing 30 changed files with 2,638 additions and 2,254 deletions.
diff --git a/.changeset/bright-shirts-sell.md b/.changeset/bright-shirts-sell.md
@@ -0,0 +1,6 @@
+---
+'@evidence-dev/core-components': patch
+---
+
+- Switch to perfect-debounce instead of lodash.debounce
+- Remove all lodash.library in favor of better supported lodash/library
diff --git a/.changeset/few-worms-fix.md b/.changeset/few-worms-fix.md
@@ -0,0 +1,5 @@
+---
+'@evidence-dev/core-components': patch
+---
+
+Rewrite Dropdown + DropdownOptionStore
diff --git a/.changeset/large-coins-crash.md b/.changeset/large-coins-crash.md
@@ -0,0 +1,9 @@
+---
+'@evidence-dev/component-utilities': patch
+'@evidence-dev/plugin-connector': patch
+'@evidence-dev/preprocess': patch
+'@evidence-dev/universal-sql': patch
+'@evidence-dev/core-components': patch
+---
+
+Update vitest to latest
diff --git a/.changeset/lucky-hounds-lie.md b/.changeset/lucky-hounds-lie.md
@@ -0,0 +1,5 @@
+---
+'@evidence-dev/sdk': patch
+---
+
+Modify default search threshold behavior for Query
diff --git a/.gitignore b/.gitignore
@@ -34,4 +34,6 @@ packages/extension/out
 packages/extension/dist
 packages/extension/.vscode-test
 packages/extension/*.vsix
-packages/extension/.DS_Store
+packages/extension/.DS_Store
+packages/ui/core-components/coverage
+sites/docs/.evidence/meta/query-cache/hashes.json
diff --git a/packages/lib/component-utilities/package.json b/packages/lib/component-utilities/package.json
@@ -11,7 +11,7 @@
 	"license": "MIT",
 	"devDependencies": {
 		"@faker-js/faker": "^8.0.2",
-		"vitest": "^0.34.1"
+		"vitest": "^2.0.5"
 	},
 	"scripts": {
 		"test": "vitest --run",

diff --git a/packages/lib/component-utilities/src/echarts.js b/packages/lib/component-utilities/src/echarts.js
@@ -24,7 +24,7 @@ export default (node, option) => {
 	registerTheme('evidence-light', evidenceThemeLight);
 
 	const chart = init(node, 'evidence-light', {
-		renderer: useSvg ? 'svg' : option.renderer ?? 'canvas'
+		renderer: useSvg ? 'svg' : (option.renderer ?? 'canvas')
 	});
 
 	// If connectGroup supplied, connect chart to other charts matching that connectGroup

diff --git a/packages/lib/component-utilities/src/getStackPercentages.js b/packages/lib/component-utilities/src/getStackPercentages.js
@@ -8,7 +8,6 @@ export default function getStackPercentages(data, groupCol, valueCol) {
 			groupBy(groupCol, mutateWithSummary({ xTotal: sum(valueCol) })),
 			mutate({ percentOfX: rate(valueCol, 'xTotal') }),
 			rename({
-				[valueCol]: valueCol + '_raw',
 				percentOfX: valueCol + '_pct'
 			})
 		);
@@ -34,7 +33,6 @@ export default function getStackPercentages(data, groupCol, valueCol) {
 				pctData,
 				mutate({ percentOfX: rate(valueCol[i], 'xTotal') }),
 				rename({
-					[valueCol[i]]: valueCol[i] + '_raw',
 					percentOfX: valueCol[i] + '_pct'
 				})
 			);

diff --git a/packages/lib/component-utilities/src/stores.js b/packages/lib/component-utilities/src/stores.js
@@ -79,7 +79,7 @@ const getStoreVal = (store) => {
  * @returns {Writable<T>}
  */
 export const localStorageStore = (key, init) => {
-	const store = writable(browser ? JSON.parse(localStorage.getItem(key)) ?? init : init);
+	const store = writable(browser ? (JSON.parse(localStorage.getItem(key)) ?? init) : init);
 	const { subscribe, set } = store;
 
 	/** @type {(v: T) => void} */

diff --git a/packages/lib/plugin-connector/package.json b/packages/lib/plugin-connector/package.json
@@ -49,7 +49,7 @@
 		"parcel": "2.12.0",
 		"rollup": "^4.13.0",
 		"typescript": "5.4.2",
-		"vitest": "^0.34.1"
+		"vitest": "^2.0.5"
 	},
 	"targets": {
 		"types": false,

diff --git a/packages/lib/preprocess/package.json b/packages/lib/preprocess/package.json
@@ -37,7 +37,7 @@
 		"mock-fs": "^5.2.0",
 		"parcel": "^2.8.3",
 		"typescript": "5.4.2",
-		"vitest": "^0.34.2"
+		"vitest": "^2.0.5"
 	},
 	"main": "dist/index.cjs",
 	"module": "dist/index.mjs",

diff --git a/packages/lib/sdk/src/plugins/datasources/wrapSimpleConnector.js b/packages/lib/sdk/src/plugins/datasources/wrapSimpleConnector.js
@@ -33,7 +33,7 @@ export const wrapSimpleConnector = (mod, source) => {
 				// Why is the dirent interface so unstable?
 				// This behaves differently depending on which minor version of 18 / 20 you are using
 				const dirPath =
-					'parentPath' in sourceFile ? sourceFile.parentPath + '' : sourceFile.path ?? dir;
+					'parentPath' in sourceFile ? sourceFile.parentPath + '' : (sourceFile.path ?? dir);
 				if (sourceFile.name === 'connection.yaml' || sourceFile.name === 'connection.options.yaml')
 					continue;
 				if (sourceFile.isDirectory()) {

diff --git a/packages/lib/sdk/src/types/mosaic-sql.d.ts b/packages/lib/sdk/src/types/mosaic-sql.d.ts
@@ -2,6 +2,7 @@ declare module '@uwdata/mosaic-sql' {
 	type BuilderFunction = <T extends any[] = unknown[]>(...args: T) => Query;
 
 	class Query {
+		distinct: BuilderFunction;
 		from: BuilderFunction;
 		select: BuilderFunction;
 		$select: BuilderFunction;

diff --git a/packages/lib/sdk/src/usql/query/Query.js b/packages/lib/sdk/src/usql/query/Query.js
@@ -711,7 +711,6 @@ DESCRIBE ${this.text.trim()}
 	};
 
 	/**
-	 *
 	 * @param {import('../types.js').QueryReactivityOpts<any>} reactiveOpts Callback that is executed when the new query is ready
 	 * @param {import('../types.js').QueryOpts<any>} [opts]
 	 * @param {QueryValue<any>} [initialQuery]
@@ -1195,10 +1194,14 @@ DESCRIBE ${this.text.trim()}
 	/**
 	 * @param {string} searchTerm
 	 * @param {string | string[]} searchCol
-	 * @param {number} searchThreshold
+	 * @param {number | undefined} [searchThreshold]
 	 * @returns {QueryValue<RowType & {similarity: number}>}
 	 */
-	search = (searchTerm, searchCol, searchThreshold = 0.5) => {
+	search = (searchTerm, searchCol, searchThreshold) => {
+		if (typeof searchThreshold === 'undefined' || searchThreshold < 0 || searchThreshold > 1) {
+			// By default, increase threshold as more characters are added
+			searchThreshold = 1 - 1 / searchTerm.length;
+		}
 		/** @type {import('../../types/duckdb-wellknown.js').DescribeResultRow[]} */
 		const colsWithSimilarity = [
 			...this.#columns,

diff --git a/packages/lib/sdk/src/utils/batchUp.js b/packages/lib/sdk/src/utils/batchUp.js
@@ -2,7 +2,7 @@ import { debounce } from 'perfect-debounce';
 
 /**
  * @template Input
- * @param {(inputs: Input[]) => unknown} fn
+ * @param {((inputs: Input[]) => unknown) | ((...i: (Input[] | Input)[]) => unknown)} fn
  * @param {number} [timeout=200]
  * @returns {(i: Input) => unknown}
  */

diff --git a/packages/lib/telemetry/index.cjs b/packages/lib/telemetry/index.cjs
@@ -96,10 +96,10 @@ const logEvent = async (
 ) => {
 	try {
 		const usageStats = settings
-			? settings.send_anonymous_usage_stats ?? 'yes'
-			: process.env['SEND_ANONYMOUS_USAGE_STATS'] ??
+			? (settings.send_anonymous_usage_stats ?? 'yes')
+			: (process.env['SEND_ANONYMOUS_USAGE_STATS'] ??
 				process.env['send_anonymous_usage_stats'] ??
-				'yes';
+				'yes');
 		let repo;
 		let database;
 		let demoDb;

diff --git a/packages/lib/universal-sql/package.json b/packages/lib/universal-sql/package.json
@@ -42,6 +42,6 @@
 		"@types/node": "20.11.28",
 		"@types/mock-fs": "^4.13.1",
 		"mock-fs": "^5.2.0",
-		"vitest": "^0.34.1"
+		"vitest": "^2.0.5"
 	}
 }