Feature symfony7 update #306
Conversation
|
@snipershady please run the check and fix the issues before I can merge it. Thanks. |
Michael I've fixed, now all PHPunit tests are succesfully completed
|
|
Nope, still not passing.. https://github.com/excelwebzone/EWZRecaptchaBundle/actions/runs/7359000381/job/20033164385?pr=306 |
|
Oo I forgot what php < 7.3 does not support strict type declartion for attributes... let me fix it again with legacy compatibility |
because we cannot run test with Symfony 7.0 on PHP < 8.2 I think we should create a new branch of the package with PHP 8.2 strict compatibility, if we want to run this bundle on symfony 7. composer.json of symfony what do you think about? |
|
I've updated the arraylist of version and tests for CI 🤞 |
|
Sorry. Still not working.. Right now I don't have a lot of time to spend on this.. but once I'd I will try to fix your PR |
I've rollback to some backward legacy compatibility for the deprecated PHP version |
|
Still not working. I don't think you can convert to PHP7 unless you remove all previous versions. Sorry :-( |
it is on you, I do not want to change compatibilty of the package with legacy versions, but it seams to be necessary. |
| @@ -26,7 +27,7 @@ public function __construct(array $options = null, string $message = null, strin | |||
| /** | |||
| * @return string|string[] | |||
| */ | |||
| public function getTargets() | |||
| public function getTargets(): array|string | |||
There was a problem hiding this comment.
Union Type is not supported by PHP 7.x, please remove it
| @@ -37,12 +38,11 @@ class IsTrueValidator extends ConstraintValidator | |||
| * | |||
| * @var bool | |||
| */ | |||
| protected $verifyHost; | |||
| protected bool $verifyHost; | |||
There was a problem hiding this comment.
Typed properties are supported by PHP 7.4+
You need to remove bool to keep compatibility with lower PHP version
| * @param ContainerBuilder $container | ||
| * @return array|string|false | ||
| */ | ||
| private function getTwigFormResources(ContainerBuilder $container): array|string|false |
|
|
||
| /** | ||
| * The reCAPTCHA server URL. | ||
| * | ||
| * @var string | ||
| */ | ||
| protected $recaptchaApiServer; | ||
| protected string $recaptchaApiServer; |
There was a problem hiding this comment.
Please removes all property types from that class
| if (forms.length) { | ||
| var recaptchaSubmitEvent = document.createEvent('Event'); | ||
| let recaptchaSubmitEvent = document.createEvent('Event'); |
There was a problem hiding this comment.
This is unrelated to Symfony 7
|
This PR can be closed |
Now compliant with Symfony 7.0