Approaches for reverse-string #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacG
reviewed
Jan 21, 2024
exercises/practice/reverse-string/.articles/performance/content.md
Outdated
Show resolved
Hide resolved
exercises/practice/reverse-string/.articles/performance/content.md
Outdated
Show resolved
Hide resolved
exercises/practice/reverse-string/.articles/performance/content.md
Outdated
Show resolved
Hide resolved
exercises/practice/reverse-string/.articles/performance/content.md
Outdated
Show resolved
Hide resolved
exercises/practice/reverse-string/.articles/performance/content.md
Outdated
Show resolved
Hide resolved
| - `< <(printf "%s" "%string)` is redirecting (`<`) a [process substitution][process-subst] (`<(...)`). | ||
| We could use a [here-string][here-string] (`<<< "$string"`), but that appends a newline. | ||
| Using `printf` like that redirects the string exactly as it is. | ||
| - `IFS= read -d "" -r -n 1 char` OK there's a lot going on there with this [`read` command][read]: |
There was a problem hiding this comment.
Suggested change
| - `IFS= read -d "" -r -n 1 char` OK there's a lot going on there with this [`read` command][read]: | |
| - `IFS= read -d "" -r -n 1 char` there's a lot going on there with this [`read` command][read]: |
There was a problem hiding this comment.
I'll use
- `IFS= read -d "" -r -n 1 char`: There's a lot going on there with this [`read` command][read].
exercises/practice/reverse-string/.articles/performance/content.md
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,5 @@ | |||
| ```bash | |||
| while IFS= read -d "" -r -n 1 char; do | |||
| echo "$char" | |||
There was a problem hiding this comment.
Suggested change
| echo "$char" | |
| echo -n "$char" |
Co-authored-by: Isaac Good <[email protected]>
…t.md Co-authored-by: Isaac Good <[email protected]>
…t.md Co-authored-by: Isaac Good <[email protected]>
…t.md Co-authored-by: Isaac Good <[email protected]>
…t.md Co-authored-by: Isaac Good <[email protected]>
…t.md Co-authored-by: Isaac Good <[email protected]>
…t.md Co-authored-by: Isaac Good <[email protected]>
IsaacG
reviewed
Jan 21, 2024
IsaacG
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus a performance article.