-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concept: Commands and Arguments #699
Conversation
Thank you for the details comments. I'll process them anon. Taking a step back, are there any topics in there that don't need to be in the first concept document? Is it too wordy, too detailed? |
I think you did a good job here. It's a bit wordy for my tastes, but I also prefer reading terse We could ask for a volunteer with less bash experience to do a read through of the contents once the PR is ready (or after the syllabus is coming together but before a release) to give us an "outsider" perspective. |
Reading it over, I'm thinking the whole Strings section can be removed. I'd like to trim down the paragraphs above Strings, but quoting is super important. |
Removed "strings" section. Removed "review" section in the middle of the document. Removed note about Windows editors and line endings. Trimmed some of the fat. Lowercased "bash" except at start of sentences.
@glennj is this still in Draft? Or rather, it is, but should it be? |
Right, getting close. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a solid intro doc.
$ [ -f file ] | ||
``` | ||
|
||
(We see a lot of people who are confused by this behavior; they think that they can omit the whitespace between `[` and its arguments, so we need to present this particular example early.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, Wooledge is a Wiki. Anything we copy/paste then change, that change can also be applied upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested to remove the extra blank line (in both files).
fi | ||
# => glennj is in the first half of the alphabet | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fi | ||
# => glennj is in the first half of the alphabet | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The discussion on the forums is here. Maybe edit the first message with the link? |
The first concept in the syllabus.