-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Verbose Unit Testing for Comprehensive Testing Summary #680
Conversation
Use verbose unit testing to output a more comprehensive testing summary (particularly for the CLI users).
This is a great improvement and will help students better parse the test output. It also seems to be compatible with the test runner. See https://forum.exercism.org/t/use-verbose-unit-testing-for-comprehensive-testing-summary/9030/3 for the corresponding discussion. @yctai1994 CI is failing for the test runner integration: https://github.com/exercism/julia/actions/runs/7344277878/job/20336362109?pr=680 That said, https://github.com/exercism/julia-test-runner/blob/main/test/fixtures/nested/runtests.jl seems to imply that nested tests should work, so I'm not sure if the CI script should be modified instead. Could you look into this? Note to self: merge this with |
Ok, I am gonna take a look! |
The error
seems to come from here: According to the comment in the codes above, it was derived from Based on the official |
It looks like the Julia test runner is on version 1.8.5 though: https://github.com/exercism/julia-test-runner/blob/909745737f454ca92870235aa702a446fd71a64d/Dockerfile |
Ok. So, the warning is gone after forking the repo: https://github.com/exercism/julia-test-runner , with a very simple workaround on line 22, from ReportingTestSet(desc) = ReportingTestSet(desc, []) to ReportingTestSet(desc; args...) = ReportingTestSet(desc, []) Should I make a pull request? |
Yes please! |
Done! Here is the pull request. |
Merged! That PR did indeed fix things. Thanks a lot! The test results on the website now look like this: What I would propose is:
Would you be up for that? |
Sure, I'll gradually get them done. I think it should be better to open an issue, right? That will be able to track the progress of this task easily.
For this part, I might need to check the details of julia-test-runner first. Once I confirm that I can address it, I'll go ahead and open a pull request there. |
Yes please! Ping me in the issue and I'll re-open it.
Great. It's not urgent right now, but will be once we get a bunch of these PRs merged. |
Description:
This pull request proposes enhancing the unit testing verbosity to provide a more comprehensive testing summary, which is particularly beneficial for CLI users. Here, I modified a single file to demo the result.
Changes Made:
exercises/practice/pangram/runtests.jl
to implement verbose unit testing.Screenshots:
Before (Previous Testing Output):
After (Enhanced Verbose Testing Output):
Proposed Benefit:
It enhanced the readability and comprehensibility of testing output, especially for CLI users.
Future Scope:
If this proposal is accepted, I plan to modify the other practices' unit testing further.