Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resistor-color exercise #702

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Conversation

BNAndras
Copy link
Member

@BNAndras BNAndras commented Feb 5, 2024

Related to #675

Copy link
Contributor

@cmcaine cmcaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Please apply changes from review, otherwise same as others: approaches file would be nice, but not necessary.

Copy link
Contributor

@cmcaine cmcaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the changes. Please either:

  • merge
  • or add approaches and re-request review
  • or dispute changes

@BNAndras
Copy link
Member Author

BNAndras commented Feb 8, 2024

I don't have write access to the repo so I can't merge. However, since you wanted approaches written, I can take a look at that. I'm not sure how interesting that would be. I think it'd just be use a collection or use the if-else constructs. I can work on that next week though.

@cmcaine cmcaine merged commit 8649085 into exercism:main Feb 9, 2024
11 checks passed
@BNAndras BNAndras deleted the add-resistor-color branch February 9, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants