-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lasagna] revision to existing concept exercise #780
base: main
Are you sure you want to change the base?
Conversation
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
Update: one test is failing on Julia 1.6, the current LTS version, but passes on 1.10, the current latest release. I'll add a guard clause to this test and push a revision. FYI - 1.6 will probably be dropped by the end of this year, when 1.11 is released and 1.10 becomes LTS. |
|
||
julia> -1234 | ||
-1234 | ||
Global variables, created outside any function, are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The heading refers to constants but we don't mention constant until later. Perhaps we should introduce what a constant is first and then discuss global variables to show why a constant is preferred.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extensively reworded. What do you think of the new attempt?
Co-authored-by: András B Nagy <20251272+BNAndras@users.noreply.github.com>
Co-authored-by: András B Nagy <20251272+BNAndras@users.noreply.github.com>
There's stuff I need to do for the next couple of hours. I'll go through your suggestions again later today and push the changes. This exercise has been rumbling around for about 5 years. so it would be good to finally get it right! |
Fixing the requested change I missed in the previous commit.
Once we agree on the |
I'm trying to keep this first exercise to a minimum, so leaving out implicit multiplication was deliberate. I'm thinking of adding a I haven't made progress on this in the last few days, other than reading around some other tracks. Blame some passing infection and associated fever (the sort of non-specific thing that epidemiologists lump together as ILI (Influenza-Like Infection) and normal people might call "something going around"). Not an aid to clear thinking. |
I hope you feel better soon! |
|
||
julia> -16 | ||
-16 | ||
These mostly work conventionally: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is a little confusing since we don’t detail what’s not conventional in the next few lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update tomorrow.
|
||
Depending on which other programming languages you know, you may expect parameters, variables or return values to have explicit type annotations. | ||
For now, assume that Julia will infer the types automagically and don't worry about them, we will get to the specifics of the type system in later exercises. | ||
By convention, variable, constant, and function names are *lowercase*, with underscores kept to a reasonable minimum. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe some examples just to be clear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like something that should be expanded in basics/about.md
. I'm trying hard to keep introduction.md
to the bare minimum needed to solve the exercise. Jeremy has said repeatedly that this is what he wants, and I'm not disagreeing.
Co-authored-by: András B Nagy <20251272+BNAndras@users.noreply.github.com>
oops... Co-authored-by: András B Nagy <20251272+BNAndras@users.noreply.github.com>
For discussion on the forum
This revision (the most recent of many):
introduction.md
to meet Exercism guidelines.config.sys
to thebasics
concept, instead of 3 older ones.The old documentation isn't wasted: I moved some to
basics/about.md
and some to later concepts.Including the
introduction.md.tpl
was my mistake. It should probably be removed now we no longer need to combine bits from 3 concepts.