Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Roman Numerals] add practice exercise (v2) #311

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

colinleach
Copy link
Contributor

Let's try this again, on a new day.

For the week of [02-06]. The example.R doesn't exactly showcase R's best features, but it's the best I've come up with so far.

@colinleach
Copy link
Contributor Author

colinleach commented Jan 28, 2024

I have some draft approaches ready to PR, but I'll wait until this exercise is merged so I have a base for adding the .approaches directory.

I think this link is to the new branch on my fork.

@jonmcalder
Copy link
Member

Sorry for the slow turnaround @colinleach! Haven't forgotten about this and will review as soon as possible.

@jonmcalder
Copy link
Member

Agree that the example solution might not be the most elegant or idiomatic R code (appending within a loop), but it gets the job done and no reason to hold back on adding this exercise (it's late and I'm not in the right headspace to think of alternatives right now)

I removed myself from authors (you've been generously including me as co-author in many of your PR's but that's only really necessary if the review substantially changes or adds to the PR)

@jonmcalder jonmcalder merged commit 146a088 into exercism:main Feb 1, 2024
3 checks passed
@colinleach
Copy link
Contributor Author

Once the exercise is merged I can rebase the approaches and PR them. There might be better solutions in there, that can be copied across later.

@jonmcalder
Copy link
Member

I've just skimmed through the approaches in your branch which look good - thanks. I'm sure we can get those merged in over the weekend ahead of next week's #48in24

@colinleach colinleach deleted the roman-numerals branch February 1, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants