Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add matrix exercise #360

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Add matrix exercise #360

merged 1 commit into from
Oct 13, 2024

Conversation

ErikSchierboom
Copy link
Member

No description provided.

@exercism exercism deleted a comment from github-actions bot Oct 12, 2024
colinleach
colinleach approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@colinleach colinleach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linters are valuable, but I find this one a bit over-pedantic for my tastes.

@colinleach
Copy link
Contributor

It took me a while to work out why you need both unlist and as.vector. It really tries hard to hold on to the names otherwise.

Use of unname instead of as.vector does the same thing, and may be a bit more clear in its intention?

@ErikSchierboom
Copy link
Member Author

Fair point! i've updated

@colinleach colinleach merged commit a03ce18 into main Oct 13, 2024
3 checks passed
@colinleach colinleach deleted the matrix branch October 13, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinleach colinleach colinleach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErikSchierboom @colinleach