fix: Prevent external users from receiving notifications of published news from a space which they are not members - EXO-69079 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… news from a space which they are not members - EXO-69079
mkrout
requested changes
Jan 29, 2024
| profile.setAttribute(UserProfile.OTHER_KEYS[2],"true"); | ||
| organizationService.getUserProfileHandler().saveUserProfile(profile,true); | ||
| LOG.debug("External info added in gatein profile for user {}, {}ms", username, System.currentTimeMillis() - startTimeForUser); | ||
| } |
There was a problem hiding this comment.
please add log here to show progression: nb of users executed/ total number of users
|
azayati
reviewed
Jan 30, 2024
| @@ -74,7 +74,7 @@ | |||
| <name>plugin.upgrade.target.version</name> | |||
| <description>The plugin target version (will not be executed if previous version is equal or higher than 6.3.1) | |||
| </description> | |||
| <value>6.3.0</value> | |||
| <value>6.6.x</value> | |||
There was a problem hiding this comment.
it is just to test acceptance, we set the correct version for the merge!
| @@ -40,6 +42,14 @@ public UserSetExternalInGateinPortal(OrganizationService organizationService,Ini | |||
|
|
|||
| } | |||
| @Override | |||
| public boolean shouldProceedToUpgrade(String newVersion, | |||
There was a problem hiding this comment.
why do we need that @sofyenne ?
There was a problem hiding this comment.
To ensure that the upgrade plugin executes only once!
exo-swf
pushed a commit
that referenced
this pull request
Jan 31, 2024
… news from a space which they are not members - EXO-69079 (#200) Prior to this change, external users were receiving notifications of published news from a space in which they were not members. This issue was caused by the absence of external property information in the gatein profile, which was only present in the social profile. After updating the ExternalUersLinstenerImp to set the external status in the gatein profile for the newly created users , this change will re-execute the ExternalUserUpgradePlugin to set the external status in the gatein profile for the previously created users.
sofyenne
added a commit
that referenced
this pull request
Jan 31, 2024
… news from a space which they are not members - EXO-69079 (#200) Prior to this change, external users were receiving notifications of published news from a space in which they were not members. This issue was caused by the absence of external property information in the gatein profile, which was only present in the social profile. After updating the ExternalUersLinstenerImp to set the external status in the gatein profile for the newly created users , this change will re-execute the ExternalUserUpgradePlugin to set the external status in the gatein profile for the previously created users.
sofyenne
added a commit
that referenced
this pull request
Jan 31, 2024
… news from a space which they are not members - EXO-69079 (#200) Prior to this change, external users were receiving notifications of published news from a space in which they were not members. This issue was caused by the absence of external property information in the gatein profile, which was only present in the social profile. After updating the ExternalUersLinstenerImp to set the external status in the gatein profile for the newly created users , this change will re-execute the ExternalUserUpgradePlugin to set the external status in the gatein profile for the previously created users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, external users were receiving notifications of published news from a space in which they were not members. This issue was caused by the absence of external property information in the gatein profile, which was only present in the social profile.
After updating the ExternalUersLinstenerImp to set the external status in the gatein profile for the newly created users , this change will re-execute the ExternalUserUpgradePlugin to set the external status in the gatein profile for the previously created users.